Skip to content

(MODULES-6330) PDK convert 1.4.1 #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2018
Merged

(MODULES-6330) PDK convert 1.4.1 #961

merged 3 commits into from
Mar 1, 2018

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Mar 1, 2018 •
edited
Loading

This PR will make this module compatible with the PDK.

@pmcmaw pmcmaw changed the title WIP - (MODULES-6330) - PDK convert 1.4.1 (MODULES-6330) - PDK convert 1.4.1 Mar 1, 2018
@pmcmaw pmcmaw requested a review from HelenCampbell March 1, 2018 14:52
HelenCampbell
HelenCampbell approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@HelenCampbell HelenCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@david22swan david22swan merged commit 26ce6fa into puppetlabs:master Mar 1, 2018
@hunner hunner changed the title (MODULES-6330) - PDK convert 1.4.1 (MODULES-6330) PDK convert 1.4.1 Mar 16, 2018
@hunner hunner added the feature label Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelenCampbell HelenCampbell HelenCampbell approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmcmaw @HelenCampbell @hunner @david22swan